Back
[15:52:10] <jepler> # Your branch is behind 'origin/master' by 11647 commits, and can be fast-forwarded.
[15:52:20] <jepler> boy, you don't pay attention to linux kernel development for a few months, and look what happens!
[15:52:35] <cradek_> cradek_ is now known as cradek
[15:52:42] <jepler> 9677 files changed, 849009 insertions(+), 467919 deletions(-)
[19:28:31] <psha> jepler: here?
[19:29:40] <jepler> psha: what's up?
[19:30:12] <psha> small review
[19:30:40] <psha> http://psha.org.ru/cgit/psha/emc2.git/commit/?h=gladevcp-axis&id=5c6d9f60993c82f2b71c4f11cc94f1296f7e57ad
[19:32:08] <psha> this allows usage of gladevcp panels just where pyvcp one is living
[19:32:28] <psha> in proper layer so it's under error messages and not over them :)
[19:32:36] <jepler> psha: if the user specifies both panels in inifile it'll load both and display just one
[19:32:40] <jepler> or did I Miss something?
[19:33:03] <psha> i think it'll load both and display both
[19:33:09] <psha> have to test though
[19:33:11] <jepler> no, they're both gridded at the same location
[19:33:54] <jepler> if vcp and gladevcp: complain loudly
[19:34:04] <jepler> # ^^^ because this is a stupid configuration that we don't want to try to support
[19:34:08] <mhaberler> it's a vlaid ppoint:
[19:34:39] <mhaberler> valid
[19:34:39] <psha> jepler: correct, but it may be easily fixed with replacing column=4 to column=5 in gladevcp
[19:38:21] <jepler> psha: quite liekyl
[19:38:24] <jepler> ow my typing
[19:43:53] <psha> sorry, had some keyboard issues
[19:44:49] <psha> how it's better to notify user about both pyvcp/gladevcp?
[19:45:01] <psha> die with error message to console or something else?
[19:46:52] <andypugh> Anything would be better than the current pyvcp behaviour, where it just dies with no hint what the problem is.
[19:47:17] <mhaberler> when does it die?
[19:47:29] <psha> i think if something is bad in .xml file
[19:47:31] <jepler> psha: I'm trying to decide whether it's better to allow both, even though I think no sensible user would ever uave both
[19:47:46] <psha> jepler: i see at least one use case - migration
[19:48:43] <jepler> andypugh: not even a python traceback when starting emc on the terminal?
[19:49:13] <andypugh> Yes, anything bad in the XML file and emc quits without clue. After a while you learn that quits without an error message are xml problems, so there is a clue-by-omission there.
[19:49:48] <andypugh> jepler: If I recall correctly, no. I might be misremebering, it's been a while.
[19:51:19] <jepler> psha: fine, unless it makes a miscolored 1-pixel strip or something else that we identify as a problem, grid the gladevcp in the next column and call it good
[19:51:44] <psha> amending
[19:52:00] <jepler> andypugh: ugh, I didn't realize that. somebody should figure out and do something (looks like I did at least once, back at 4c1c10)
[19:54:36] <psha> http://psha.org.ru/cgit/psha/emc2.git/commit/?h=gladevcp-axis&id=de9df2a905541ea4a20f26f6eb42be30f46f21ca
[19:55:07] <andypugh> It might already be fixed then, or perhaps at the time I wasn't adept enough at checking error logs.
[19:55:07] <psha> i think no extra pixel line is added
[19:55:11] <psha> as i may see
[19:55:28] <psha> but even if it's there it's impossible to see it - panels have 4px padding ;)
[19:55:50] <andypugh> Let me see what is involved in making a deliberately broken test.
[19:55:55] <jepler> psha: hmmm this makes me realize something
[19:56:04] <jepler> we only loaded a gladevcp if hal_preset == 1
[19:56:07] <jepler> hal_present
[19:56:27] <jepler> if hal_present (which I think originates from the environment) is false, axis isn't supposed to do anything hal-related
[19:56:31] <psha> correct, i've lost it
[19:56:50] <psha> i think then all dynamic tab blocks has to be wrapped?
[19:56:55] <jepler> welllllll
[19:57:05] <jepler> you'll tell me: no, a camview tab doesn't do anything hal-related
[19:57:13] <jepler> ugh
[19:57:30] <psha> i think it's ok not to load dynamic tabs whe hal is not present
[19:58:16] <psha> what are use cases of no-HAL axis?
[19:58:31] <mhaberler> meager
[19:59:17] <jepler> psha: two reasons. first, the mythical use of NML over the network so that AXIS runs on a different system than the realtime software. second, for development so that you can start axis multiple times within a single emc session
[20:00:02] <psha> i think then it's better to wait for tabs only when hal_present=1
[20:00:10] <psha> if not present - no waiting
[20:00:17] <psha> non hal tabs will work, hal - wont
[20:01:31] <jepler> the point in waiting is to run the postgui halfile, but that shouldn't be run in the case of !hal_present
[20:02:12] <psha> yes, and postgui is executed after waiting
[20:02:21] <psha> so no waiting - no postgui halfile
[20:03:05] <jepler> I see that postgui_halfile was run regardless of hal_present
[20:03:19] <psha> yes, i've missed that point
[20:03:25] <jepler> no, I mean before any of your changes
[20:07:11] <psha> http://psha.org.ru/cgit/psha/emc2.git/commit/?h=gladevcp-axis&id=882d51336824e331949f2f3ecd9fa86566dbbaf3
[20:07:14] <psha> something like this
[20:07:30] <psha> wait for childs _and_ execute postgui only when hal_present=1
[20:09:25] <psha> http://psha.org.ru/cgit/psha/emc2.git/commit/?h=gladevcp-axis&id=2f18e6
[20:09:46] <psha> this one is better - it deiconifies axis window if hal not present )
[20:16:38] <andypugh> I withdraw my statement about pyvcp quitting without an error message. Either it has been fixed, or I was just wrong.
[20:42:48] <jepler> psha: better all the time
[20:42:51] <jepler> andypugh: thanks for checking that!
[20:46:43] <psha> jepler: man pages are added by hand?
[20:48:17] <jepler> psha: except for .comp files, manpages are written by hand
[20:49:28] <jepler> psha: if that doesn't answer the question you were asking, please try asking a slightly different question
[20:50:06] <psha> i've just merged mhaberler's manpage for gladevcp and just was curious if it's correct way :)
[20:50:17] <psha> so it's anwsered my question
[20:50:25] <psha> i think i'm ready for merge now
[20:51:35] <psha> running last tests to ensure i've not broke something on merge ;)
[20:55:22] <jepler> andypugh: I took a look at the code for gearchange.comp (your message dated 2 Dec 2010) and I don't spot any glaring errors. You think it's ready for incorporation in master? Is there a later version?
[20:58:04] <andypugh> The version on my drive was last edited on the 3rd.
[20:58:11] <andypugh> I wonder what changed?
[20:58:31] <jepler> the 2 Dec mail was about the comp bug with parameters with personality that you discovered
[20:58:41] <jepler> I would not be surprised if you were just looking for a workaround for it?
[20:59:25] <andypugh> The one that got fixed elsewhere?
[20:59:32] <andypugh> Could be
[20:59:35] <jepler> yes, it was a bug in comp and I fixed it.
[21:05:22] <andypugh> There is a very subtle change, I changed the line-wrap on the pin desciriptions to honour the 80 column width
[21:05:49] <andypugh> There were no functional changes
[21:07:22] <jepler> send me that version, then?
[email protected]
[21:12:55] <psha> jepler: take a look at 'gladevcp' branch when you have a minute
[21:12:59] <psha> i think it's ready
[21:13:13] <psha> axis integration and some persistence cleanups
[21:16:31] <andypugh> I wonder if there is a way to make hal components polymorphic? It would be very nice if the mux2, mux4 components could adapt to the attached signals.
[21:17:20] <andypugh> I doubt it could be done in a way whch would let you run them in a base thread, though.
[21:22:48] <psha> andypugh: i guess it's hard since pins are created before they are connected
[21:23:14] <psha> you either need to create many pins or create many components - mux2b, mux2f, ...
[21:25:07] <andypugh> You can create pins on-demand depending on the declaration modparam, but you are right that it is too late once you start wiring the signals.
[21:26:28] <andypugh> There are some curious quirks, such as mux2 being float and sample_hold being s32. (you can use mux2 as a float sample-hold, but not vice-versa)
[21:39:25] <skunkworks> andypugh: I just use the logic comp - (needed a 3 input and gate) and after figuring out the incantation - it worked great!
[21:42:50] <psha> jepler: i have to go now, so if you think 'gladevcp' branch is fine - please merge it
[21:43:00] <psha> i'll check in the morning
[21:43:34] <psha> if something is not ok - just write here, i'll check logs
[21:43:40] <psha> logger_dev: bookmark
[21:43:40] <psha> Just this once .. here's the log:
http://www.linuxcnc.org/irc/irc.freenode.net:6667/emcdevel/2010-12-20.txt
[21:43:55] <psha> at least now logger is up :)
[21:43:58] <psha> bb all
[21:56:25] <jepler> andypugh: a non-'comp' component could take the type of pins to create as a module parameter..
[21:57:15] <andypugh> cfg=u32,s32,bit...
[21:57:59] <andypugh> Not allowing duplicate names is a comp thing not a hal thing, isn't it?
[21:58:36] <andypugh> And default pehaviour could remain the same.
[21:59:28] <andypugh> I ought to make this 8i20 driver stop bricking the drives first though.
[21:59:40] <CIA-2> EMC: 03jepler 07master * r2edf1a912721 10/ (lib/python/gladevcp/xembed.py src/hal/user_comps/gladevcp.py): gladevcp: Reorder initialization/cleanup code
[21:59:40] <jepler> andypugh: not allowing a pin and a parameter to have the same name is a comp thing
[21:59:41] <CIA-2> EMC: 03jepler 07master * r954d9488b6ea 10/ (3 files in 3 dirs): gladevcp: Keyboard events forwardind (axis)
[21:59:42] <CIA-2> EMC: 03jepler 07master * r2ce59e65125f 10/src/emc/usr_intf/axis/scripts/axis.py: axis: Execute POSTGUI_HALFILE after all child processes
[21:59:44] <CIA-2> EMC: 03jepler 07master * r90624f8d6d96 10/lib/python/gladevcp/persistence.py: gladevcp: persistence.py simplified
[21:59:46] <CIA-2> EMC: 03jepler 07master * rb851c0e7f8c7 10/configs/gladevcp/ (7 files in 4 dirs): gladevcp: Move configs to simplified presistence
[21:59:52] <CIA-2> EMC: 03jepler 07master * r2f18e6930067 10/src/emc/usr_intf/axis/scripts/axis.py: gladevcp: Use gladevcp in same place where PyVCP live
[21:59:55] <jepler> not allowing two pins or two parameters to have the same name is a hal thing
[21:59:55] <CIA-2> EMC: 03jepler 07master * rcdac8820809e 10/ (9 files in 6 dirs): Merge branch 'gladevcp-axis', remote branch 'void/gladevcp-persistence-simplified2' into gladevcp
[21:59:56] <CIA-2> EMC: 03jepler 07master * r40a18779d76f 10/docs/man/man1/gladevcp.1: gladevcp: add man page
[21:59:57] <CIA-2> EMC: 03jepler 07master * rfb748fed714c 10/lib/python/gladevcp/xembed.py: gladevcp: Change XEmbed order
[22:00:23] <jepler> psha, mhaberler: thanks, I didn't spot any problems.
[22:25:42] <mhaberler> psha is off for today. I gave it a spin as well and didnt see anything suspicious.
[22:25:44] <mhaberler> Thanks!
[23:15:25] <mhaberler> jepler: I fear we have missed the python-configobj dependency in debian/control.in
[23:15:26] <mhaberler> sorry about that