#emc-devel | Logs for 2011-03-11

Back
[00:04:23] -!- theorbtwo has quit [Ping timeout: 252 seconds]
[00:04:28] theorb is now known as theorbtwo
[00:04:55] -!- JT-Shop has quit [Quit: ChatZilla 0.9.86 [Firefox 3.6.15/20110303024726]]
[00:17:31] -!- andypugh has quit [Quit: andypugh]
[00:20:11] -!- robh__ has quit [Ping timeout: 248 seconds]
[00:26:56] -!- Connor has quit [Ping timeout: 276 seconds]
[00:31:32] -!- tlab has quit [Quit: Leaving]
[00:41:31] -!- snoop has quit [Ping timeout: 248 seconds]
[01:19:41] -!- HDB10 has quit [Quit: Ex-Chat]
[01:28:21] -!- awallin [awallin!~quassel@173-166-160-241-washingtondc.hfc.comcastbusiness.net] has joined #emc-devel
[01:28:50] -!- servos4ever has quit [Quit: ChatZilla 0.9.85 [SeaMonkey 2.0.11/20101206162726]]
[01:34:45] -!- skunkworks [skunkworks!~chatzilla@str-bb-cable-south2-static-6-412.dsl.airstreamcomm.net] has joined #emc-devel
[01:59:17] -!- tlab has quit [Ping timeout: 255 seconds]
[02:23:35] -!- tlab has quit [Ping timeout: 255 seconds]
[03:12:52] -!- Techrat has quit [Quit: Leaving]
[03:29:03] -!- awallin has quit [Remote host closed the connection]
[03:31:27] -!- seb_kuzminsky [[email protected]] has joined #emc-devel
[03:59:53] -!- skunkworks has quit [Ping timeout: 255 seconds]
[04:10:32] -!- adb has quit [Ping timeout: 276 seconds]
[04:43:51] -!- KimK has quit [Quit: Leaving]
[04:50:13] -!- KimK [[email protected]] has joined #emc-devel
[04:51:01] -!- OoBIGeye has quit [Ping timeout: 260 seconds]
[05:26:11] -!- kvirdi has quit [Read error: Connection reset by peer]
[05:33:17] -!- kvirdi has quit [Read error: Connection reset by peer]
[05:39:16] -!- kvirdi has quit [Read error: Connection reset by peer]
[05:43:54] -!- ve7it has quit [Remote host closed the connection]
[05:43:54] -!- kvirdi has quit [Read error: Connection reset by peer]
[05:59:09] -!- psha [[email protected]] has joined #emc-devel
[06:03:51] -!- kvirdi has quit [Read error: Connection reset by peer]
[06:05:51] -!- kvirdi has quit [Read error: Connection reset by peer]
[06:12:53] -!- kvirdi has quit [Read error: Connection reset by peer]
[06:13:23] -!- waynegramlich has quit [Remote host closed the connection]
[06:18:56] -!- kvirdi has quit [Read error: Connection reset by peer]
[06:20:45] -!- kvirdi has quit [Read error: Connection reset by peer]
[06:24:45] -!- kvirdi has quit [Read error: Connection reset by peer]
[06:29:32] -!- kvirdi has quit [Read error: Connection reset by peer]
[06:31:45] -!- kvirdi has quit [Read error: Connection reset by peer]
[06:35:35] -!- kvirdi has quit [Read error: Connection reset by peer]
[06:55:15] -!- kvirdi has quit [Read error: Connection reset by peer]
[06:57:07] -!- kvirdi has quit [Read error: Connection reset by peer]
[07:00:37] -!- kvirdi has quit [Read error: Connection reset by peer]
[07:16:40] -!- kvirdi has quit [Read error: Connection reset by peer]
[07:26:46] -!- OoBIGeye has quit [Ping timeout: 260 seconds]
[07:31:29] -!- mk0 has quit [Remote host closed the connection]
[07:31:30] -!- kvirdi has quit [Read error: Connection reset by peer]
[07:33:38] -!- Dannyboy has quit [Remote host closed the connection]
[07:35:37] -!- kvirdi has quit [Read error: Connection reset by peer]
[07:40:07] -!- kvirdi has quit [Read error: Connection reset by peer]
[07:45:44] -!- robh__ [[email protected]] has joined #emc-devel
[07:45:44] -!- kvirdi has quit [Read error: Connection reset by peer]
[07:55:45] -!- kvirdi has quit [Read error: Connection reset by peer]
[07:56:27] -!- kvirdi has quit [Client Quit]
[07:58:34] -!- mg_cnc [[email protected]] has joined #emc-devel
[08:03:24] -!- mg_cnc has quit [Quit: Leaving]
[08:32:44] -!- pingufan has quit [Remote host closed the connection]
[09:00:02] -!- davec has quit [Disconnected by services]
[09:21:46] -!- pingufan has quit [Remote host closed the connection]
[09:22:00] -!- EDocToor has quit [Read error: Operation timed out]
[09:28:20] -!- psha has quit [Quit: Lost terminal]
[09:41:21] -!- mk0 has quit [Quit: Leaving]
[10:41:16] -!- KimK has quit [Ping timeout: 240 seconds]
[10:54:59] -!- KimK [[email protected]] has joined #emc-devel
[11:21:55] -!- adb [[email protected]] has joined #emc-devel
[11:39:35] -!- adb has quit [Ping timeout: 252 seconds]
[11:46:14] -!- pingufan has quit [Remote host closed the connection]
[12:07:36] -!- awallin [awallin!~quassel@173-166-160-241-washingtondc.hfc.comcastbusiness.net] has joined #emc-devel
[12:08:20] -!- awallin has quit [Client Quit]
[12:08:26] -!- awallin [awallin!~quassel@173-166-160-241-washingtondc.hfc.comcastbusiness.net] has joined #emc-devel
[12:15:47] -!- pjm__ has quit [Ping timeout: 255 seconds]
[12:28:28] -!- pingufan has quit [Remote host closed the connection]
[12:28:35] -!- psha [[email protected]] has joined #emc-devel
[12:31:49] -!- adb [[email protected]] has joined #emc-devel
[12:44:19] <alex_joni> psha: around?
[12:53:45] <psha> yes
[13:16:18] <alex_joni> hi, sorry, was on another desktop :)
[13:16:54] <psha> :)
[13:17:01] <psha> time for cup of tea :)
[13:17:04] <psha> bb in ~10 min
[13:17:09] <alex_joni> just one sec
[13:17:17] <alex_joni> I was looking over html docs: http://www.linuxcnc.org/docs/devel/html/config/ini_config.html
[13:17:25] <alex_joni> any idea why the indenting is off?
[13:17:45] <alex_joni> for example in 2.2 [DISPLAY] -> POSITION_OFFSET
[13:18:24] -!- Ekken_ has quit [Ping timeout: 246 seconds]
[13:21:08] <jthornton> might be something not cleared after the bullet list
[13:25:34] -!- pingufan has quit [Remote host closed the connection]
[13:27:38] <psha> alex_joni: yes, i think it's due to 'list in list'
[13:27:41] <psha> i'll check it now
[13:29:22] <alex_joni> might have been a parsing error?
[13:29:29] <alex_joni> I mean converting from lyx to html
[13:29:41] <alex_joni> to asciidoc :/ (sorry a bit distracted)
[13:31:03] -!- skunkworks [skunkworks!447329d2@gateway/web/freenode/ip.68.115.41.210] has joined #emc-devel
[13:31:28] <psha> maybe i've missed extra line break :)
[13:37:07] <psha> yes, i think it's due to improper conversion - i'd better explicitely terminate lists
[13:39:52] <SWPadnos> huh: http://www.fcsuper.com/swblog/?p=2662
[13:40:04] <alex_joni> oh SWPadnos, good you're here
[13:40:11] <SWPadnos> uh-oh
[13:40:17] <SWPadnos> err. hi
[13:40:23] <psha> SWPadnos: may you set up fetching last html logs?
[13:40:53] <SWPadnos> well, I might have some time on Sunday ...
[13:40:58] <alex_joni> or set psha up for pushing
[13:41:18] <alex_joni> psha: could you maybe integrate the old logs too (didn't check if you have them on your site or not)
[13:41:32] <SWPadnos> anyone with the emcboard login can write the script ... :)
[13:41:34] <psha> i have them
[13:41:41] <psha> and they are in search too
[13:41:57] <alex_joni> SWPadnos: then cron it?
[13:42:05] <SWPadnos> yep
[13:42:08] -!- findux has quit [Quit: Page closed]
[13:42:23] <psha> SWPadnos: so when you'll have time - add cron job at 0:30 UTC to grab last log from http://psha.org.ru/irc/#channel/DATE.html
[13:42:34] <psha> or if it's missing - from mhaberlers' one
[13:42:58] <SWPadnos> ok, I'm sure we (ie, someone else) can get that done soon :)
[13:43:01] <alex_joni> psha:I'll try to do it, if SWPadnos is buusy
[13:43:09] <SWPadnos> I'm buuuuuuuusy :)
[13:43:11] <psha> at least cmorley complained about outdated logs
[13:43:16] <alex_joni> heh, that was a typo ;)
[13:43:17] <psha> alex_joni: ok
[13:43:37] <SWPadnos> yeah. I haven't even looked to see whether the logger is on in a couple of weeks
[13:43:46] <psha> http://psha.org.ru/cgit/psha/emc2.git/commit/?h=doc-fixes
[13:43:48] <alex_joni> nope it's not
[13:44:24] <psha> here are two clones of one logger and system is pretty stable
[13:44:40] <psha> logger[mah]: .
[13:44:40] <logger[mah]> psha: Log stored at http://emc.mah.priv.at/irc/%23emc-devel/2011-03-11.html
[13:45:35] <alex_joni> logger[psha]_: .
[13:46:24] <SWPadnos> ok, so at 0:30 UST, grab the log from "yesterday" UTC, and ideally stick it in a year/month/logname file (or maybe just year/logname)
[13:46:34] <SWPadnos> s/UST/UTC/
[13:47:07] <archivist> alex_joni, and a spare copy here :) http://emc-devellog.archivist.info/previous.php
[13:47:07] <SWPadnos> bbl
[13:47:40] <archivist> we need a merge to fixup datetimes :)
[14:02:44] -!- WalterN has quit [Read error: Connection reset by peer]
[14:05:09] -!- JT-Shop [[email protected]] has joined #emc-devel
[14:12:52] <psha> archivist: i've expilitely set UTC tz for logger
[14:13:09] <psha> instead of normal MSK/MSD tz
[14:13:17] <psha> so i guess it's best choice
[14:27:06] -!- psha has quit [Read error: No route to host]
[14:30:32] -!- psha [[email protected]] has joined #emc-devel
[14:48:30] -!- awallin has quit [Remote host closed the connection]
[14:57:14] <seb_kuzminsky> SWPadnos: huh, draftsight for linux
[14:57:20] <seb_kuzminsky> i'm not sure if that's good or bad
[14:59:18] -!- JT-Shop has quit [Quit: ChatZilla 0.9.86 [Firefox 3.6.15/20110303024726]]
[15:00:19] <seb_kuzminsky> their deb is 69 MB
[15:02:52] <archivist> psha, I would have to do some tz mods as its stored in a database across many chans
[15:09:23] <cradek> some slashdot commenter said "This isn't a FOSS 2d CAD package. It's a proprietary program that you can download at no charge but it requires "activation" within 30 days and once per year thereafter. (I just read the FAQ on their website.)"
[15:09:48] <cradek> their website isn't answering so I can't verify that
[15:13:42] -!- pcw_home has quit [Remote host closed the connection]
[15:14:51] -!- mk0 has quit [Quit: Leaving]
[15:20:21] <seb_kuzminsky> lol, their faq is a pdf
[15:21:04] <archivist> I have a hatred of pdfs :)
[15:23:07] <seb_kuzminsky> hm, they only have 32-bit debs
[15:23:13] * seb_kuzminsky looks areound for a 32-bit vm
[15:24:31] <seb_kuzminsky> they're targeting Karmic
[15:27:40] -!- skunkworks has quit [Ping timeout: 245 seconds]
[15:28:21] -!- skunkworks [skunkworks!447329d2@gateway/web/freenode/ip.68.115.41.210] has joined #emc-devel
[15:30:01] <cradek> When a user saves or
[15:30:01] <cradek> prints a document for the first time, they will be asked to activate the product within 30 days
[15:30:04] <cradek> using a valid email address and reactivate after six months and thereafter at 12-month
[15:30:07] <cradek> intervals. Users will need an Internet connection to download and activate.
[15:30:11] <cradek> PASS
[15:32:54] <archivist> I think its the thing originally from solidworks
[16:02:50] -!- Farthen has quit [Ping timeout: 240 seconds]
[16:09:32] -!- nullie has quit [Quit: Ex-Chat]
[16:13:52] -!- adb has quit [Ping timeout: 250 seconds]
[16:21:19] <alex_joni> None shall PASS
[16:22:26] <alex_joni> http://www.youtube.com/watch?v=gXY9TuuwyL8
[16:25:26] -!- ve7it [[email protected]] has joined #emc-devel
[16:40:49] -!- psha has quit [Quit: Lost terminal]
[16:42:30] -!- JT-Work has quit [Client Quit]
[16:43:08] -!- adb [[email protected]] has joined #emc-devel
[17:00:22] -!- JT-Work [[email protected]] has joined #emc-devel
[17:05:47] -!- JT-Work has quit [Remote host closed the connection]
[17:51:13] -!- MarkusBec has quit [Excess Flood]
[17:53:16] -!- adb has quit [Ping timeout: 260 seconds]
[17:56:03] -!- MarkusBec has quit [Excess Flood]
[18:13:20] -!- JT-Work [[email protected]] has joined #emc-devel
[18:18:26] -!- adb [[email protected]] has joined #emc-devel
[18:19:06] -!- andypugh [andypugh!~andy2@cpc2-basl1-0-0-cust1037.basl.cable.virginmedia.com] has joined #emc-devel
[18:19:24] -!- JT-Work has quit [Quit: ChatZilla 0.9.86 [Firefox 3.6.15/20110303024726]]
[18:30:57] -!- motioncontrol1 has quit [Client Quit]
[18:31:46] -!- motioncontrol has quit [Ping timeout: 260 seconds]
[18:43:32] -!- mhaberler [[email protected]] has joined #emc-devel
[18:49:08] -!- JT-Work [[email protected]] has joined #emc-devel
[19:21:35] -!- mhaberler has quit [Ping timeout: 252 seconds]
[19:23:17] -!- mhaberler [[email protected]] has joined #emc-devel
[19:25:29] -!- mk0 has quit [Ping timeout: 264 seconds]
[19:28:02] -!- psha [[email protected]] has joined #emc-devel
[19:38:30] <cradek> psha, JT-Work: do you have any insight on http://article.gmane.org/gmane.linux.distributions.emc.devel/4157
[19:39:34] -!- EDocToor [[email protected]] has joined #emc-devel
[19:39:54] <JT-Work> seems like he commited it to master not 2.4
[19:40:18] <cradek> http://www.linuxcnc.org/docs/devel/html/drivers/pico_ppmc.html has changes from commit 3bc4cda5709
[19:40:27] <JT-Work> I saw the commit and saw it on the devel documents
[19:40:55] <JT-Work> yea, that is where I saw it too
[19:41:35] <JT-Work> I assume he wanted to commit it to 2.4 at the time
[19:41:39] <cradek> ok I will answer
[19:42:27] <JT-Work> thanks, I advised him to ask you or jepler on how to cherry pick or what ever a while back
[19:47:49] <cradek> the markup's slightly weird in that file, lots of extra ```
[19:48:13] <JT-Work> wonder how he edited it
[19:48:26] <cradek> he used lyx before the ascii conversion
[19:48:51] <psha> cradek: i'll check commit graph
[19:49:23] <psha> if it's in master then it may have sliped somewhere between conversions
[19:49:44] <cradek> his changes are in 2.5 as far as I can tell
[19:49:53] <cradek> I don't think you did anything wrong
[19:50:12] <cradek> I'm not sure what he's expecting that he's not seeing - JT-Work thinks maybe he meant to change 2.4
[19:51:19] <psha> cradek: his changes are in .txt
[19:51:20] <JT-Work> he was expecting to go to documents online and see it
[19:51:32] <cradek> well there are lots of documents online :-)
[19:51:56] <psha> as far as i understand
[19:51:57] <JT-Work> I mean the current release documents
[19:52:00] <psha> at least partialy ;)
[19:52:29] <JT-Work> here http://www.linuxcnc.org/docview/html/drivers_pico_ppmc.html
[19:52:29] <psha> for example commit introduces this phrase
[19:52:31] <psha> + -- Velocity scaled in user units per second.
[19:52:32] <cradek> maybe he is looking here: http://www.linuxcnc.org/docview/html/drivers_pico_ppmc.html
[19:52:34] <psha> + -- Velocity scaled in user units per second.
[19:52:43] <psha> and it's in converted docs
[19:52:46] <cradek> yes
[19:52:47] <cradek> ok thanks
[19:52:50] <JT-Work> yes, that is where he looked
[20:17:44] -!- mhaberler has quit [Ping timeout: 276 seconds]
[20:32:33] -!- Guest192 has quit [Client Quit]
[20:33:59] -!- psha has quit [Ping timeout: 276 seconds]
[20:38:45] <andypugh> noob question: When would you use #include <filename> and when #include "filename" ?
[20:41:15] <archivist> one is library includes <filename> iirc
[20:41:16] <cradek> <> is for system includes, "" are for your own .h files
[20:43:08] <andypugh> Aha, that makes sense.
[20:43:38] <andypugh> You can tell who has just copied and pasted the first several lines of his files so far, can't you?
[20:45:19] <JT-Work> ha, I knew that :) I am suprised
[20:48:28] <andypugh> Yay! The SPI driver additions compile! Now to put the actual code in the functions :-)
[20:56:14] -!- mozmck_work1 has quit [Quit: Leaving.]
[20:57:29] -!- x_ [[email protected]] has joined #emc-devel
[20:57:39] -!- Dallur has quit [Read error: Connection reset by peer]
[20:57:58] x_ is now known as micges
[21:02:02] -!- JT-Work has quit [Quit: ChatZilla 0.9.86 [Firefox 3.6.15/20110303024726]]
[21:11:14] <CIA-5> EMC: 03micges 07v2.4_branch * rf282805ef819 10/src/emc/usr_intf/halui.cc: halui: fix pin name typo
[21:12:17] <seb_kuzminsky> seems dangerous to rename pins deep in the stable branch - it'll break existing configs that rely on that old typo
[21:12:55] <seb_kuzminsky> i think i'd prefer to note the type in the docs in 2.4, and fix the typo (and un-update the docs) in 2.5
[21:14:01] <micges> oh shit
[21:14:16] <micges> I mean to do this in 2.5 ...
[21:15:39] <cpresser_> since we are speaking of typos.. i found one in comp
[21:15:41] <cpresser_> http://pastebin.com/gpux3kk4
[21:19:40] <CIA-5> EMC: 03micges 07v2.4_branch * r30465e0db831 10/src/emc/usr_intf/halui.cc: Revert "halui: fix pin name typo"
[21:21:22] <seb_kuzminsky> cpresser_: nice catch
[21:21:31] <seb_kuzminsky> i'm not sure that patch is right, though
[21:21:56] <andypugh> I am not sure the typo matters either, userinit works...
[21:22:15] <seb_kuzminsky> the comp docs describe a function named userinit(), not user_init()
[21:22:18] <cpresser_> sorry, i am not a real programmer. i just found it while debugging my comp-file
[21:22:27] <seb_kuzminsky> no comp currently uses user_init or userinit
[21:23:11] <cpresser_> thats the function i use with my com-file "static void user_init(int argc, char **argv) {" ... and it gets called
[21:23:12] <seb_kuzminsky> the only comp that uses the userinit option is andy's bldc.comp, and it does not actually supply a userinit function
[21:23:30] <seb_kuzminsky> cpresser_: yes, and that violates the docs ;-)
[21:24:21] <cpresser_> i am using 2.4.5; /usr/bin/comp, at line 841 adds a call to the function user_init(arc,arv)
[21:24:23] <seb_kuzminsky> the docs say to call it userinit(), not user_init(): http://linuxcnc.org/docs/devel/html/hal/comp.html, search for init
[21:26:11] <seb_kuzminsky> if the .comp has "option userinit yes", then comp incorrectly adds a declaration for user_init(), and correctly calls userinit()
[21:26:30] <seb_kuzminsky> i think it should add a declaration for userinit(), and call userinit(), since that's what the docs say
[21:26:49] <cpresser_> http://git.linuxcnc.org/gitweb?p=emc2.git;a=blob;f=src/hal/utils/comp.g;h=775d8b1b29be4c7f125cb36ada0771133eb1bc16;hb=refs/heads/v2.4_branch
[21:26:57] <cpresser_> line 550 and 544
[21:27:10] -!- motioncontrol has quit [Quit: Sto andando via]
[21:27:23] <cpresser_> right, seb_kuzminsky. that sounds reasonable
[21:36:37] <CIA-5> EMC: 03seb 07v2.4_branch * rdabdc1c152f4 10/src/hal/utils/comp.g: comp: fix a typo in generated code
[21:36:47] <seb_kuzminsky> thanks Carsten
[21:37:05] <cpresser_> no problem. ty for working on the code :)
[21:38:50] <andypugh> My brian hurts. http://wiki.linuxcnc.org/cgi-bin/emcinfo.pl?SPI_Sub-Driver_For_Hostmot2
[21:39:01] <seb_kuzminsky> cpresser_: if you name your function userinit(), like the docs say, it should work now
[21:39:09] <seb_kuzminsky> (after the buildbot finishes and you upgrade)
[21:39:30] <andypugh> The modparams for SPIFrames are OK, until you realise that there are 4 different types of SPI module in HM2
[21:39:41] <seb_kuzminsky> hah
[21:40:12] <seb_kuzminsky> andypugh: i think the wiki page is way off in the weeds
[21:40:55] <andypugh> I think I will do what I used to do when I had a girlfriend and housework needed doing, make a half-assed attempt and then let somebody competent take over :-)
[21:43:07] <andypugh> More seriously, I guess it will shake down to something that works once I get into it.
[21:49:05] -!- findux has quit [Quit: Page closed]
[21:49:12] <CIA-5> EMC: 03micges 07joints_axes3 * ra197341fc2af 10/src/emc/usr_intf/halui.cc: halui: create proper joints pins count according to ini file
[21:58:32] -!- e3m has quit [Client Quit]
[22:00:44] -!- psha [[email protected]] has joined #emc-devel
[22:09:29] -!- psha has quit [Quit: Lost terminal]
[22:21:25] -!- skunkworks has quit [Ping timeout: 245 seconds]
[22:42:11] -!- acemi has quit [Quit: WeeChat 0.3.2]
[22:43:42] -!- micges has quit [Quit: Ex-Chat]
[23:01:07] -!- Dallur has quit [Quit: Leaving.]
[23:04:01] <andypugh> I am vaguely considering creating an "example.c" Hostmot2 driver in the src tree. This would not be in the makefile, but would simply be a stripped-down example of what Hostmot2 driver modules look like, and tend to include. So all the checks, create one pin, one write TRAM, one read TRAM etc. Is that a dreadful idea?
[23:13:33] <seb_kuzminsky> that reminds me
[23:13:56] <seb_kuzminsky> back at the last cnc workshop in ann arbor, i started a branch to make it easier to write new hm2 sub-drivers
[23:14:04] <andypugh> Yes, I know, we need to abstract HM2 to reduce the duplicated code?
[23:14:15] <seb_kuzminsky> it's been bit-rotting away somewhere in my git repo
[23:14:48] <andypugh> I agree aesthetically
[23:15:12] <seb_kuzminsky> oh, here it is: http://git.highlab.com/?p=emc2.git;a=shortlog;h=refs/heads/subdriver
[23:15:29] <seb_kuzminsky> here's the most interesting commit: http://git.highlab.com/?p=emc2.git;a=commit;h=8d3a96223152bc3f62c3c8773e7f3397ccd88742
[23:15:55] <seb_kuzminsky> it's all outdated and would need some tlc before it can be useful
[23:16:29] <andypugh> But the current messy situation works, and allows each new feature Pete comes up with to be individually wierd in its own way. Whilst an abstracted, generic structure would be lovely, making it flexible enough to deal with anything sounds hard.
[23:16:34] <seb_kuzminsky> here's the general idea: http://git.highlab.com/?p=emc2.git;a=blob;f=src/hal/drivers/mesa-hostmot2/hostmot2.h;h=77e23c9aaacc678f96f132ef172b43eb80903081;hb=8d3a96223152bc3f62c3c8773e7f3397ccd88742#l772
[23:17:37] <seb_kuzminsky> andypugh: agreed, the ioport twiddling you did for sserial made me question the subdriver architecture
[23:19:07] <andypugh> I am half-way through making a template file (guaranteed not to compile, which is deliberate) which is the simplest-possible sub driver for an "example" function.
[23:19:34] <seb_kuzminsky> i'm not a huge fan of contrived examples
[23:19:45] <seb_kuzminsky> i prefer the actual working code to be clean and simple enough to act as an example
[23:19:51] <andypugh> I like your approach more, but that is a job for someone bette than me.
[23:19:55] <seb_kuzminsky> maybe the led.c code could serve this purpose
[23:19:56] <seb_kuzminsky> ?
[23:20:01] <seb_kuzminsky> that's pretty simple
[23:20:33] <andypugh> I thought exactly that, but then realised that I stripped some checks out of that because it is so simple.
[23:21:41] <andypugh> I am actually in the middle of editing -out anything not generic in pwmgen.c to see what that leaves us with.
[23:22:41] <andypugh> Also, there is a problem with led.c I need to fix. The board-id string is different dependent on who built the firmware.
[23:24:03] <andypugh> So with a 5i23 and and a PCW firmware it tries to create 7 Leds because board_id is "MESA5I23" but the driver assumes "HM2_5i23"
[23:24:23] <seb_kuzminsky> yes, i noticed that too
[23:24:32] <seb_kuzminsky> but i was too disorganized to do anything about it :-(
[23:25:09] -!- tlab has quit [Remote host closed the connection]
[23:25:20] <andypugh> While berating you for disorganised-ness, Gearchange?
[23:25:29] <seb_kuzminsky> i think the right fix is to add a field to hm2_lowlevel_io_t that reports the number of LEDs
[23:25:44] <seb_kuzminsky> board-specific stuff belongs in lowlevel, not sprinkled through-out the subdrivers
[23:25:52] <seb_kuzminsky> just like connectors are handled
[23:26:00] <andypugh> Whereas the easy fix is to check for both string in led.c
[23:26:12] <seb_kuzminsky> no, that's wrong, don't do it that way
[23:26:17] <seb_kuzminsky> that just perpetuates the bogusness
[23:26:21] <andypugh> OK, won't.
[23:26:24] <seb_kuzminsky> if you're going to fix it, fix it right
[23:26:41] <andypugh> With _my_ reputation? Are you mad?
[23:26:52] <seb_kuzminsky> heh
[23:28:17] <andypugh> You are right, though. I was just shy of messing with anyone else's code
[23:29:05] -!- tlab has quit [Client Quit]
[23:32:43] <andypugh> looking, it seems like a natural extension to hm2_pci_probe, board->llio.num_ioport_connnectors = 3 ; num_leds=3...
[23:33:07] <andypugh> At the point where there is no ambiguity.
[23:33:49] <andypugh> Though it is a remarkably minor issue, as they all have a register for 32 leds anyway.
[23:37:40] -!- findux has quit [Ping timeout: 245 seconds]
[23:39:30] -!- EDocToor has quit [Read error: Connection reset by peer]
[23:44:50] <seb_kuzminsky> andypugh: the led subdriver exports a single bit pin for each LED on the board, so it needs to know
[23:45:23] <seb_kuzminsky> the led subdriver also uses the notion of "instance" differently than the rest of the subdrivers
[23:45:29] <seb_kuzminsky> bbl
[23:45:47] <andypugh> Yes, but it is a non-issue if someone writes a 1 to a non-existent LED
[23:46:05] <andypugh> And yes, it's a bit different from most, so not a great example
[23:54:58] -!- EDocToor [[email protected]] has joined #emc-devel